Alter expand/collapse text when adding/removing parts #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fofr
force-pushed
the
collapse-all-new-groups
branch
from
5515ab1
to
da8737a
Compare
|
Rebased with master so it's merge-able again. |
|
Intermittent test failures being addressed in #362 |
Use the events emitted by the nested form javascript to trigger changes in the link text for collapsing or expanding groups. For example: * When a part is added and all parts were collapsed, change text to “expand” * When a part is removed and it was the only open part, change text to “expand” * Remove the “if valid” check on the collapse class. All parts are shown expanded at page load, and all should be collapsible.
fofr
force-pushed
the
collapse-all-new-groups
branch
from
da8737a
to
a713638
Compare
|
Good for merge once build goes green. |
fofr
added a commit
that referenced
this pull request
Feb 2, 2015
Alter expand/collapse text when adding/removing parts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the events emitted by the nested form javascript to trigger changes in the link text for collapsing or expanding groups. Also remove the “if valid” check on the collapse class. All parts are shown expanded at page load, and all should be collapsible.
For example: